Fix dask_cudf metadata-inference when first ORC path is empty #8021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjzamora
added
bug
kkraus14
approved these changes
Apr 21, 2021
|
rerun tests |
kkraus14
added
5 - Ready to Merge
|
@gpucibot merge |
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #8021 +/- ##
==============================================
Coverage ? 82.95%
==============================================
Files ? 103
Lines ? 17722
Branches ? 0
==============================================
Hits ? 14701
Misses ? 3021
Partials ? 0 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8011
Dask-cuDF currently reads a single stripe to infer metadata in
read_orc. When the first path corresponds to an empty file, there is no stripe "0" to read. This PR includes a simple fix (and test coverage).